From ecb7a1ab93b1ad4d56728b0cc041f5f7cf3e9107 Mon Sep 17 00:00:00 2001 From: Philip Henning Date: Thu, 14 Aug 2025 09:04:25 +0200 Subject: [PATCH] Update key bindings to match project brief --- internal/tui/update.go | 8 ++++---- memory-bank/activeContext.md | 4 ++-- memory-bank/progress.md | 1 + tests/tui_test.go | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/internal/tui/update.go b/internal/tui/update.go index e29fd15..8092961 100644 --- a/internal/tui/update.go +++ b/internal/tui/update.go @@ -18,13 +18,13 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) { } else { m.focus = listPane } - case "e": + case "ctrl+e": if m.mode == ViewMode { m.mode = EditMode } else { m.mode = ViewMode } - case "a": + case " ": if m.mode == EditMode { if entry := m.SelectedEntry(); entry != nil { entry.Active = !entry.Active @@ -34,7 +34,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) { } case "up", "k": if m.focus == detailPane { - m.detail.LineUp(1) + m.detail.ScrollUp(1) } else { m.list, cmd = m.list.Update(msg) m.refreshDetail() @@ -42,7 +42,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) { return m, cmd case "down", "j": if m.focus == detailPane { - m.detail.LineDown(1) + m.detail.ScrollDown(1) } else { m.list, cmd = m.list.Update(msg) m.refreshDetail() diff --git a/memory-bank/activeContext.md b/memory-bank/activeContext.md index c19e750..5a6e125 100644 --- a/memory-bank/activeContext.md +++ b/memory-bank/activeContext.md @@ -24,8 +24,8 @@ - ✅ **Parser integration** loading `/etc/hosts` into the UI ### Phase 3: Edit Mode (IN PROGRESS) -- 🔄 **Edit mode toggle** via 'e' key with status bar indication -- 🔄 **Entry activation toggle** using 'a' key +- 🔄 **Edit mode toggle** via 'ctrl+e' key with status bar indication +- 🔄 **Entry activation toggle** using spacebar - 🔄 **Model tests** covering edit mode behavior ### Parser Capabilities Achieved diff --git a/memory-bank/progress.md b/memory-bank/progress.md index aedc400..13272c7 100644 --- a/memory-bank/progress.md +++ b/memory-bank/progress.md @@ -80,6 +80,7 @@ - **Active work**: Expand edit mode with file integration and advanced editing - **Blockers**: None - comprehensive parser foundation with 54 tests completed - **Parser status**: Production-ready with all safety features implemented +- **Key bindings updated**: `ctrl+e` for edit mode, spacebar to toggle entries ### Development Readiness - ✅ **Architecture designed**: Clear technical approach documented diff --git a/tests/tui_test.go b/tests/tui_test.go index a73719a..ae7ce72 100644 --- a/tests/tui_test.go +++ b/tests/tui_test.go @@ -72,12 +72,12 @@ func TestEditModeToggleAndActivation(t *testing.T) { m := tui.NewModel(hf) // enter edit mode - nm, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'e'}}) + nm, _ := m.Update(tea.KeyMsg{Type: tea.KeyCtrlE}) m = nm.(tui.Model) assert.Equal(t, tui.EditMode, m.Mode()) // toggle active state of first entry - nm, _ = m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}}) + nm, _ = m.Update(tea.KeyMsg{Type: tea.KeySpace}) m = nm.(tui.Model) assert.False(t, m.SelectedEntry().Active)