phg/hosts
0
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

Refactor DNS resolution tests to use direct async functions for mocking and improve clarity

Browse source
This commit is contained in:
Philip Henning 2025-08-18 18:44:29 +02:00
parent 8d99cfe53c
commit 4761f48885
1 changed files with 31 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/test_dns.py
View file

@ -142,11 +142,14 @@ class TestResolveHostname:
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_empty_result_resolution(self): async def test_empty_result_resolution(self):
"""Test hostname resolution with empty result.""" """Test hostname resolution with empty result."""
async def mock_wait_for(*args, **kwargs):
return []
with patch("asyncio.get_event_loop") as mock_loop: with patch("asyncio.get_event_loop") as mock_loop:
mock_event_loop = AsyncMock() mock_event_loop = AsyncMock()
mock_loop.return_value = mock_event_loop mock_loop.return_value = mock_event_loop
with patch("asyncio.wait_for", return_value=[]): with patch("asyncio.wait_for", side_effect=mock_wait_for):
resolution = await resolve_hostname("empty.example") resolution = await resolve_hostname("empty.example")
assert resolution.hostname == "empty.example" assert resolution.hostname == "empty.example"
@ -194,9 +197,8 @@ class TestResolveHostnamesBatch:
"""Test batch resolution with mixed success/failure.""" """Test batch resolution with mixed success/failure."""
hostnames = ["example.com", "nonexistent.example"] hostnames = ["example.com", "nonexistent.example"]
with patch("src.hosts.core.dns.resolve_hostname", new_callable=AsyncMock) as mock_resolve: # Create a direct async function replacement instead of using AsyncMock
# Mock mixed results - use side_effect as a proper async function async def mock_resolve_hostname(hostname, timeout=5.0):
async def mock_side_effect(hostname, timeout=5.0):
if hostname == "example.com": if hostname == "example.com":
return DNSResolution( return DNSResolution(
hostname="example.com", hostname="example.com",
@ -213,7 +215,7 @@ class TestResolveHostnamesBatch:
error_message="Name not found", error_message="Name not found",
) )
mock_resolve.side_effect = mock_side_effect with patch("src.hosts.core.dns.resolve_hostname", mock_resolve_hostname):
resolutions = await resolve_hostnames_batch(hostnames) resolutions = await resolve_hostnames_batch(hostnames)
@ -283,7 +285,10 @@ class TestDNSService:
status=DNSResolutionStatus.RESOLVED, status=DNSResolutionStatus.RESOLVED,
resolved_at=datetime.now(), resolved_at=datetime.now(),
) )
mock_resolve.return_value = mock_resolution # Use proper async setup
async def mock_side_effect(hostname, timeout=5.0):
return mock_resolution
mock_resolve.side_effect = mock_side_effect
resolution = await service.resolve_entry_async("example.com") resolution = await service.resolve_entry_async("example.com")
@ -314,7 +319,10 @@ class TestDNSService:
status=DNSResolutionStatus.RESOLVED, status=DNSResolutionStatus.RESOLVED,
resolved_at=datetime.now(), resolved_at=datetime.now(),
) )
mock_resolve.return_value = mock_resolution # Use proper async setup
async def mock_side_effect(hostname, timeout=5.0):
return mock_resolution
mock_resolve.side_effect = mock_side_effect
result = await service.refresh_entry("example.com") result = await service.refresh_entry("example.com")