From 8b1c01c89494bce68ecbe82bdcc751c864e46454 Mon Sep 17 00:00:00 2001 From: phg Date: Wed, 30 Jul 2025 15:26:39 +0200 Subject: [PATCH] Refactor test imports: remove unused imports across configuration and modal test files --- src/hosts/core/config.py | 5 ++--- tests/test_config.py | 2 -- tests/test_config_modal.py | 5 ++--- tests/test_main.py | 6 +----- tests/test_manager.py | 4 ++-- tests/test_save_confirmation_modal.py | 3 +-- 6 files changed, 8 insertions(+), 17 deletions(-) diff --git a/src/hosts/core/config.py b/src/hosts/core/config.py index aef6855..fea36d5 100644 --- a/src/hosts/core/config.py +++ b/src/hosts/core/config.py @@ -5,7 +5,6 @@ This module handles application settings and preferences. """ import json -import os from pathlib import Path from typing import Dict, Any @@ -46,7 +45,7 @@ class Config: loaded_settings = json.load(f) # Merge with defaults to ensure all keys exist self._settings.update(loaded_settings) - except (json.JSONDecodeError, IOError) as e: + except (json.JSONDecodeError, IOError): # If loading fails, use defaults pass @@ -58,7 +57,7 @@ class Config: with open(self.config_file, 'w') as f: json.dump(self._settings, f, indent=2) - except IOError as e: + except IOError: # Silently fail if we can't save config pass diff --git a/tests/test_config.py b/tests/test_config.py index bc4a86a..4adc7ee 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -5,10 +5,8 @@ This module contains unit tests for the Config class, validating configuration loading, saving, and management functionality. """ -import pytest import tempfile import json -import os from pathlib import Path from unittest.mock import patch, mock_open diff --git a/tests/test_config_modal.py b/tests/test_config_modal.py index 7d2bbbf..52ab7d1 100644 --- a/tests/test_config_modal.py +++ b/tests/test_config_modal.py @@ -5,10 +5,9 @@ This module contains unit tests for the ConfigModal class, validating modal behavior and configuration interaction. """ -import pytest -from unittest.mock import Mock, patch +from unittest.mock import Mock -from textual.widgets import Checkbox, Button +from textual.widgets import Button from hosts.core.config import Config from hosts.tui.config_modal import ConfigModal diff --git a/tests/test_main.py b/tests/test_main.py index e0a34fd..dd9de27 100644 --- a/tests/test_main.py +++ b/tests/test_main.py @@ -5,12 +5,8 @@ This module contains unit tests for the HostsManagerApp class, validating application behavior, navigation, and user interactions. """ -import pytest -import tempfile -from unittest.mock import Mock, patch, MagicMock -from pathlib import Path +from unittest.mock import Mock, patch -from textual.widgets import DataTable, Static from hosts.main import HostsManagerApp from hosts.core.models import HostEntry, HostsFile diff --git a/tests/test_manager.py b/tests/test_manager.py index d723dad..9895b79 100644 --- a/tests/test_manager.py +++ b/tests/test_manager.py @@ -9,8 +9,8 @@ import pytest import tempfile import subprocess from pathlib import Path -from unittest.mock import Mock, patch, MagicMock -from src.hosts.core.manager import PermissionManager, HostsManager, EditModeError +from unittest.mock import Mock, patch +from src.hosts.core.manager import PermissionManager, HostsManager from src.hosts.core.models import HostEntry, HostsFile diff --git a/tests/test_save_confirmation_modal.py b/tests/test_save_confirmation_modal.py index c6c268a..a6a2acd 100644 --- a/tests/test_save_confirmation_modal.py +++ b/tests/test_save_confirmation_modal.py @@ -6,10 +6,9 @@ This module tests the save confirmation functionality when exiting edit entry mo import pytest from unittest.mock import Mock, patch -from textual.widgets import Input, Checkbox, Button +from textual.widgets import Button from hosts.main import HostsManagerApp -from hosts.core.models import HostsFile, HostEntry from hosts.tui.save_confirmation_modal import SaveConfirmationModal