Refactor test cases for improved readability and consistency
- Updated test_dns.py to enhance mock function definitions and improve spacing for better readability. - Modified test_filters.py to streamline assertions and ensure consistent formatting across test cases. - Cleaned up test_import_export.py by organizing imports and ensuring consistent formatting in CSV and JSON tests. - Improved test_main.py by refining mock setups and ensuring consistent error handling in assertions.
This commit is contained in:
parent
0710d10fac
commit
7872991e0b
42 changed files with 2376 additions and 2735 deletions
36
docs/agents/domain.md
Normal file
36
docs/agents/domain.md
Normal file
|
|
@ -0,0 +1,36 @@
|
|||
# Domain Docs
|
||||
|
||||
How engineering skills should consume this repository's domain documentation
|
||||
when exploring the codebase.
|
||||
|
||||
## Before exploring, read these
|
||||
|
||||
- **`CONTEXT.md`** at the repository root.
|
||||
- **`docs/adr/`** — read ADRs that affect the area about to be changed.
|
||||
|
||||
If either location does not exist, proceed silently. The `/domain-modeling`
|
||||
skill creates domain documentation when terminology or decisions are resolved.
|
||||
|
||||
## File structure
|
||||
|
||||
This repository uses a single-context layout:
|
||||
|
||||
/
|
||||
├── CONTEXT.md
|
||||
├── docs/
|
||||
│ └── adr/
|
||||
└── src/
|
||||
|
||||
## Use the glossary's vocabulary
|
||||
|
||||
When output names a domain concept—for example in an issue title, refactor
|
||||
proposal, hypothesis, or test name—use the term defined in `CONTEXT.md`. Avoid
|
||||
synonyms that the glossary explicitly rejects.
|
||||
|
||||
If a required concept is missing, reconsider whether the proposed language
|
||||
belongs to the project or note the gap for `/domain-modeling`.
|
||||
|
||||
## Flag ADR conflicts
|
||||
|
||||
Explicitly surface output that contradicts an existing ADR instead of silently
|
||||
overriding it.
|
||||
52
docs/agents/issue-tracker.md
Normal file
52
docs/agents/issue-tracker.md
Normal file
|
|
@ -0,0 +1,52 @@
|
|||
# Issue tracker: Forgejo
|
||||
|
||||
Issues and PRDs for this repository live as Forgejo issues in
|
||||
`git.s1q.dev/phg/hosts`. Use `fgj` for all operations.
|
||||
|
||||
Every repository-scoped command must use the hostname `git.s1q.dev` and
|
||||
repository `phg/hosts`.
|
||||
|
||||
## Conventions
|
||||
|
||||
- **Create an issue**:
|
||||
`fgj --hostname git.s1q.dev issue create -R phg/hosts --title "..." --body "..."`
|
||||
- **Read an issue**:
|
||||
`fgj --hostname git.s1q.dev issue view <number> -R phg/hosts`
|
||||
- **Read an issue as JSON**:
|
||||
`fgj --hostname git.s1q.dev issue view <number> -R phg/hosts --json`
|
||||
- **List issues**:
|
||||
`fgj --hostname git.s1q.dev issue list -R phg/hosts --state open --json`
|
||||
- **Comment on an issue**:
|
||||
`fgj --hostname git.s1q.dev issue comment <number> -R phg/hosts --body "..."`
|
||||
- **Apply or remove labels**:
|
||||
`fgj --hostname git.s1q.dev issue edit <number> -R phg/hosts --add-label "..."`
|
||||
or `--remove-label "..."`
|
||||
- **Close an issue**:
|
||||
`fgj --hostname git.s1q.dev issue close <number> -R phg/hosts --comment "..."`
|
||||
- **List repository labels**:
|
||||
`fgj --hostname git.s1q.dev label list -R phg/hosts --json`
|
||||
|
||||
## When a skill says "publish to the issue tracker"
|
||||
|
||||
Create a Forgejo issue with `fgj issue create`.
|
||||
|
||||
## When a skill says "fetch the relevant ticket"
|
||||
|
||||
Run `fgj issue view <number>` with the configured hostname and repository.
|
||||
|
||||
## Wayfinding operations
|
||||
|
||||
The map is a Forgejo issue with one child issue per ticket.
|
||||
|
||||
- **Map**: an issue labelled `wayfinder:map` containing Notes,
|
||||
Decisions-so-far, and Fog sections.
|
||||
- **Child ticket**: an issue whose body starts with `Part of #<map>` and whose
|
||||
type is recorded with a `wayfinder:<type>` label (`research`, `prototype`,
|
||||
`grilling`, or `task`).
|
||||
- **Blocking**: put `Blocked by: #<number>, #<number>` at the top of the child
|
||||
issue body. A ticket is unblocked when every listed issue is closed.
|
||||
- **Frontier**: inspect the map's open child issues and choose the first issue
|
||||
that has no open blocker and has not been claimed.
|
||||
- **Claim**: apply the `wayfinder:claimed` label before beginning work.
|
||||
- **Resolve**: comment with the answer, close the child issue, then append a
|
||||
context pointer to the map's Decisions-so-far section.
|
||||
15
docs/agents/triage-labels.md
Normal file
15
docs/agents/triage-labels.md
Normal file
|
|
@ -0,0 +1,15 @@
|
|||
# Triage Labels
|
||||
|
||||
The skills speak in terms of five canonical triage roles. This file maps those
|
||||
roles to the label strings used in this repository's Forgejo issue tracker.
|
||||
|
||||
| Label in mattpocock/skills | Label in our tracker | Meaning |
|
||||
| -------------------------- | -------------------- | ----------------------------------------- |
|
||||
| `needs-triage` | `needs-triage` | Maintainer needs to evaluate this issue |
|
||||
| `needs-info` | `needs-info` | Waiting on reporter for more information |
|
||||
| `ready-for-agent` | `ready-for-agent` | Fully specified, ready for an AFK agent |
|
||||
| `ready-for-human` | `ready-for-human` | Requires human implementation |
|
||||
| `wontfix` | `wontfix` | Will not be actioned |
|
||||
|
||||
When a skill mentions a canonical role, use the corresponding tracker label
|
||||
from this table.
|
||||
Loading…
Add table
Add a link
Reference in a new issue